Summer 2025 updates #125
Open
Summer 2025 updates #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 3020e92 in 1 minute and 0 seconds. Click for details.
- Reviewed
436lines of code in4files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. lib/generators/draft/resource/resource_generator.rb:35
- Draft comment:
Using 'singular_table_name_templates' instead of the conventional plural folder name; confirm this naming is intentional. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
2. lib/generators/draft/resource/templates/controllers/controller.rb:41
- Draft comment:
Typo: '@plural_table_name' is used in the redirect path; it should be 'plural_table_name'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. lib/generators/draft/resource/templates/views/index.html.erb:7
- Draft comment:
Refactored index view uses semantic HTML (article, header, ul); ensure the new list layout meets UI and accessibility needs. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. lib/generators/draft/resource/templates/views/show.html.erb:77
- Draft comment:
Show view markup now uses semantic elements; verify that conditional sentinel comments still work as expected. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_XCVvLSl2hH8jMfPj
You can customize 
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 2a2fdb2 in 36 seconds. Click for details.
- Reviewed
20lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. VERSION:1
- Draft comment:
Version bumped to 0.0.5. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. draft_generators.gemspec:9
- Draft comment:
s.version updated to 0.0.5. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_6GeUhqoYsG5A0vMG
You can customize
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed a41019a in 32 seconds. Click for details.
- Reviewed
48lines of code in2files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. lib/generators/draft/resource/resource_generator.rb:74
- Draft comment:
Removed extraneous whitespace in route definitions for better consistency. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, as it only states that whitespace was removed for consistency. It doesn't provide any actionable feedback or suggestions for improvement.
2. lib/generators/draft/resource/templates/controllers/controller.rb:65
- Draft comment:
Adjusted spacing inside hash literal for redirect_to in update action for consistency. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, as it only mentions an adjustment for consistency without suggesting any action or asking for confirmation. It doesn't provide any actionable feedback or raise any concerns about the code.
3. lib/generators/draft/resource/templates/controllers/controller.rb:87
- Draft comment:
Consistent formatting: added a space inside the hash literal in the destroy action redirect_to. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative and does not provide any actionable feedback or suggestions. It simply states that a space was added for consistent formatting, which does not require any action from the PR author.
Workflow ID: wflow_ucpo2uCvmvOeJ0ti
You can customize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #124
Important
Update view directory structure to use singular table names with '_templates' suffix, increment version to 0.0.5, and simplify HTML in views.
app/views/<plural_table_name>toapp/views/<singular_table_name>_templatesinresource_generator.rbandcontroller.rb.controller.rbto reflect new directory structure.0.0.4to0.0.5inVERSIONanddraft_generators.gemspec.index.html.erbandshow.html.erbby removing unnecessary<div>elements and using<article>and<header>tags.This description was created by
for a41019a. You can customize this summary. It will automatically update as commits are pushed.